Rev netlink to pick up RouteListIter #8979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
fasaxc
added
docs-not-required
Allows for listing large numbers of routes without buffering the whole list in memory at once.
This used to get filtered out by the nil check, but the netlink library now synthesizes a zero CIDR when reading the default route.
aaaaaaaalex
approved these changes
Jul 12, 2024
|
Converting to draft since the upstream repo has a critical bug that affects the commit I tried to rev to: vishvananda/netlink#959 |
|
Bad commit was reverted again, my bad |
|
@aaaaaaaalex CI fail is an nftables flake; it's with Casey. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I made a PR to the upstream netlink repo that was just merged. It changes the library's internal read loop to use an iterator, which avoid a lot of allocations (10% speedup + lower allocs in my benchmarks). There's also a new, more efficient API but I'll tackle that once the dust settles on #8418 .
Related issues/PRs
vishvananda/netlink#940
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.